test and usage of KVS

garsy020

Hi,

I test the last beta (0.11beta3) on shelly 1 plus.

For one of my project I test the new KVS and I don't understand why my var "out_the_call" is undefined in my log:

Code

mg_rpc.c:314 script.setconfig via WS_in 192.168.1.44:5051117:16:06.390
mg_rpc.c:314 script.putcode via WS_in 192.168.1.44:5051117:16:06.678
mg_rpc.c:314 script.start via WS_in 192.168.1.44:5051117:16:06.952
shelly_user_script.:403 Running 'api_math.js'...17:16:06.976
shelly_user_script.:403 Running 'init.js'...17:16:07.700
shelly_user_script.:365 mJS RAM stat: initial: 159796 after: 154808, used: 498817:16:07.180
shelly_user_script.:403 Running 'script_3.js'...17:16:07.250
[TEST] start 17:16:07.330
[TEST] out_the_call: undefined 17:16:07.490
shelly_user_script.:375 mJS RAM stat: after user code: 159796 after: 152804, used: 699217:16:07.580
shelly_notification:145 Status change of script:3: {"id":3,"running":true}17:16:07.690
mg_rpc.c:314 KVS.Set via loopback 17:16:07.860
mg_rpc.c:314 KVS.get via loopback 17:16:07.174
shelly_notification:145 Status change of sys: {"kvs_rev":34}17:16:07.183
[POOL] INTHE CALL: 13 17:16:07.206
mg_rpc.c:314 script.list via WS_in 192.168.1.44:5051117:16:07.292
mg_rpc.c:314 KVS.List via WS_in 192.168.1.44:50511

Alles anzeigen

My code:

Code

print("[TEST] start");


let out_the_call;


function kvsSet(key, value){
Shelly.call(
"KVS.Set",
{"key":key, "value":value}
);
}


function kvsGet(key){
Shelly.call(
"KVS.get",
{"key":key},
function (result) {
print("[POOL] INTHE CALL:",result.value);
out_the_call = result.value;
}
);


}
kvsSet("temp","13");


kvsGet("temp");
print("[TEST] out_the_call:",out_the_call);

Alles anzeigen

If you have one idea please

Thank you.

Seven of Nine

Shelly.Call is asynchron, so the print at the end is executed before the kvsGet() has finished.

you can validate this by adding a delay (Timer).

Code

 print("[TEST] start");
let out_the_call;


function kvsSet(key, value) {
    Shelly.call(
        "KVS.Set",
        { "key": key, "value": value }
    );
}


function kvsGet(key) {
    Shelly.call(
        "KVS.get",
        { "key": key },
        function (result) {
            print("[POOL] INTHE CALL:", result.value);
            out_the_call = result.value;
        }
    );


}
kvsSet("temp", "13");


kvsGet("temp");
Timer.set(1000, false, function (ud) {
    print("[TEST] out_the_call:", out_the_call);
}, null);
Timer.clear();

Alles anzeigen

garsy020

ARG, thank you, I suspected this...

Do you know if there is plan to make this call synchron like some other call ?

Seven of Nine

Zitat von garsy020

Do you know if there is plan to make this call synchron like some other call ?

IIRC it was synchronous at the beginning but was changed. If you'd like to control a bunch of rempote shellies via loop it is important that network latency and response for each device doesn't delay the script execution. So I doubt this will be changed back.

and there are still "workarounds" like adding a timer (my example above) or moving the related code to the response function:

Code

print("[TEST] start");
let out_the_call;


function kvsSet(key, value) {
    Shelly.call(
        "KVS.Set",
        { "key": key, "value": value }
    );
}


function kvsGet(key) {
    Shelly.call(
        "KVS.get",
        { "key": key },
        function (result) {
            print("[POOL] INTHE CALL:", result.value);
            out_the_call = result.value;

            print("[TEST] out_the_call:", out_the_call);
        }
    );


}
kvsSet("temp", "13");
kvsGet("temp");

Alles anzeigen

garsy020

Ok thanks for your reply, I understand the need about async result.

I will think about it, because timer seems to be a "crapy fix". perhaps move the code into response, but I wouldlike get the value to use it into another function.. so I will think about.

if a function require many KVS values, is very complicated to make clean code into response function....

there is a solution to be notify when response is done ?

test and usage of KVS

Ähnliche Themen

Script randomly killed on Shelly Plus 1PM

Led lamp blinking when turned off

Shelly plus 1 AC Live/Nature pin faulty after 2 months of controlling Hager ESC225 contactor